metadata_update: work on a copy of the upstream file, to not mess up the cache
#891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
adrinjalali
suggested changes
Jun 2, 2022
|
not sure what to test here TBH =) |
Isn't that what this PR enables? |
|
Ok, makes sense. Want to take a stab at it @adrinjalali? |
|
Too many things on my plat ATM. I'll leave it to your more than capable hands, or @LysandreJik if he's interested :) |
|
Pushed a quick test |
adrinjalali
reviewed
Jun 9, 2022
| f"{USER}/{self.REPO_NAME}", new_metadata, token=self._token, overwrite=True | ||
| ) | ||
|
|
||
| self.assertNotEqual(metadata_load(path), new_metadata) |
There was a problem hiding this comment.
can we also check the original file is not touched?
Closed
adrinjalali
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise if you're using the same file from another script or library you'll have incorect file.
Side effect: With this change, we can probably remove the flag
force_download=True